feat(uniswapx-sdk): Implement Dutch V3 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyborn
reviewed
Sep 11, 2024
codyborn
reviewed
Sep 11, 2024
codyborn
reviewed
Sep 11, 2024
codyborn
reviewed
Sep 12, 2024
codyborn
reviewed
Sep 12, 2024
codyborn
reviewed
Sep 12, 2024
codyborn
reviewed
Sep 12, 2024
codyborn
reviewed
Sep 12, 2024
codyborn
reviewed
Sep 12, 2024
codyborn
reviewed
Sep 17, 2024
codyborn
reviewed
Sep 18, 2024
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (09/19/24)1 reviewer was added to this PR based on 's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are adding support for the new Dutch v3 orders in the UniswapX SDK
How Has This Been Tested?
Unit testing for all files so far, will include integration after contracts are completely finalized
Are there any breaking changes?
None. V3 was intentionally written in a way that guarantees V2 doesn't break. In the future, we should consider creating a CosignedDutch class that parents classes such as V2 and V3. This would require significant refactoring but would be cleaner.