feat(sdk-core): zksync custom create2 address #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsy1218
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (06/06/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
hensha256
approved these changes
Jun 6, 2024
marktoda
approved these changes
Jun 6, 2024
|
🎉 This PR is included in version @uniswap/sdk-core-v5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
zksync-ethers use ethers 6, but our stack still uses ethers 5 across the board. We are not ready to upgrade our stack to use ethers 6, so we will implement zksync-ethers create2Address within our sdk-core
How Has This Been Tested?
I tested via a custom v3 pool address unit test written local, and address are the same without considering the case sensitivity https://app.warp.dev/block/sVW55KB4ifZKwbxC7jZs4m
Are there any breaking changes?
No
(Optional) Feedback Focus
No
(Optional) Follow Ups