feat(v2-sdk): support zksync #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jsy1218
force-pushed
the
jsy1218/v2-sdk-support-zksync
branch
from
8826595
to
0862e87
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
just checking you know that v2 isnt deployed? this code might be needed in future but will not be used for now until v2 is deployed |
hensha256
reviewed
Jun 5, 2024
| INIT_CODE_HASH | ||
| ) | ||
| const salt = keccak256(['bytes'], [pack(['address', 'address'], [token0.address, token1.address])]) | ||
| const initCodeHash = INIT_CODE_HASH |
There was a problem hiding this comment.
the initcodehash is different for zksync 😢
There was a problem hiding this comment.
we dont have a v2 one (because its not deployed) but it would be different to the EVM one
There was a problem hiding this comment.
alright, I guess I will abandon this PR for now. I thought the salt and init code hash would be the same, so that we can preempt to change the v2-sdk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are supporting ZkSync within v2-sdk. We need to update the pair address computation for zk sync.
How Has This Been Tested?
unit tests
Are there any breaking changes?
No
(Optional) Feedback Focus
No
(Optional) Follow Ups
Will locally test within SOR before merging this PR