feat(uniswapx-sdk): Update Structs & ABI functionality for Dutch V3 Gas Adjustment Feature #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (09/23/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
codyborn
reviewed
Sep 23, 2024
| @@ -364,13 +406,51 @@ describe("V3DutchOrderBuilder", () => { | |||
| ).toThrow("Invariant failed: nonce not set"); | |||
| }); | |||
|
|
|||
| it("Throw if startingBaseFee not set", () => { | |||
There was a problem hiding this comment.
Maybe add a test for when startingBaseFee and adjustmentPerGweiBaseFee are non-zero (e.g. 1e9)
codyborn
approved these changes
Sep 23, 2024
zhongeric
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Structural changes for DutchV3 to support new gas adjustment feature
This unblocks us to now write E2E integration tests
How Has This Been Tested?
Tests have been updated to check and use this field. There is no formal checking of logical bounds of the feature, which should be done when we implement support for this feature to be used.