Position Manager guide added #835
Open
+765
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@vendrell46 is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
saucepoint
requested changes
Dec 11, 2024
Comment on lines
78
to
84
| ```solidity | ||
| // Common liquidity operations | ||
| uint8 constant MINT_POSITION = 1; // Creates negative deltas (tokens needed for position) | ||
| uint8 constant INCREASE_LIQUIDITY = 2; // Creates negative deltas (tokens to add) | ||
| uint8 constant DECREASE_LIQUIDITY = 3; // Creates positive deltas (tokens to receive) | ||
| uint8 constant BURN_POSITION = 4; // Creates positive deltas (tokens to receive) | ||
| ``` |
There was a problem hiding this comment.
these command numbers were changed, i would check Actions.sol on github
There was a problem hiding this comment.
updated as per Actions.sol
Comment on lines
96
to
100
| // Common delta-resolving operations | ||
| uint8 constant SETTLE_PAIR = 10; // For negative deltas: Pay tokens to the pool | ||
| uint8 constant TAKE_PAIR = 11; // For positive deltas: Receive tokens from the pool | ||
| uint8 constant CLOSE_CURRENCY = 12; // Handles either direction based on final delta | ||
| uint8 constant CLEAR_OR_TAKE = 13; // For small amounts: Take if worth it, else ignore |
There was a problem hiding this comment.
would verify these are still true
There was a problem hiding this comment.
updated as per Actions.sol
Comment on lines
199
to
219
| ```solidity | ||
| bytes[] memory params = new bytes[](2); | ||
|
|
||
| // Parameters for MINT_POSITION | ||
| params[0] = abi.encode( | ||
| poolKey, // Which pool to mint in | ||
| tickLower, // Position's lower price bound | ||
| tickUpper, // Position's upper price bound | ||
| liquidity, // Amount of liquidity to mint | ||
| amount0Max, // Maximum amount of token0 to use | ||
| amount1Max, // Maximum amount of token1 to use | ||
| recipient, // Who receives the NFT | ||
| "" // No hook data needed | ||
| ); | ||
|
|
||
| // Parameters for SETTLE_PAIR - specify tokens to provide | ||
| params[1] = abi.encode( | ||
| poolKey.currency0, // First token to settle | ||
| poolKey.currency1 // Second token to settle | ||
| ); | ||
| ``` |
There was a problem hiding this comment.
indentation looks weird no?
| With everything prepared, we can execute our batch operation: | ||
|
|
||
| ```solidity | ||
| // Execute all operations atomically |
| abi.encode(actions, params), | ||
| block.timestamp + 60 | ||
| ); | ||
| } |
There was a problem hiding this comment.
removed for clarity
|
|
||
| This is valuable for: | ||
|
|
||
| - Fee collection with minimum amounts |
There was a problem hiding this comment.
lets remove this, doesnt seem right to me that you would just "collect fees" to forfeit immediately?
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Co-authored-by: saucepoint <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Position Manager guide added to Uniswap v4 docs