Adding arbitrum X docs #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
codyborn
reviewed
Jun 13, 2024
| # Arbitrum Pilot Overview | ||
| Starting June 19 2024, the Uniswap team will be piloting running a portion of trades on Arbitrum through UniswapX. Unlike UniswapX on mainnet, these orders will have **no RFQ portion and thus no exclusivity** during the pilot. | ||
|
|
||
| Filling on Arbitrum, however, follows the same two steps as filling on Mainnet: 1) Retrieving signed orders and 2) Filling orders. |
There was a problem hiding this comment.
Suggested change
| Filling on Arbitrum, however, follows the same two steps as filling on Mainnet: 1) Retrieving signed orders and 2) Filling orders. | |
| Filling on Arbitrum, however, follows the same two steps as filling on Mainnet: | |
| 1. Retrieving signed orders | |
| 2. Filling orders. |
codyborn
reviewed
Jun 13, 2024
| @@ -72,3 +72,36 @@ To begin testing in beta quoters will need to: | |||
| 4. **Send hashes of 5 filled transactions** that demonstrate that the integration was able to fill during the exclusive period; specifically before [decayStartTime](https://github.com/Uniswap/UniswapX/blob/abd7a0b080148fc42ef7c86536d14de714eec4c7/src/lib/ExclusiveDutchOrderLib.sol#L12) | |||
|
|
|||
| The Uniswap Labs team will review the 5 transactions to confirm they were successful exclusive fills. Once they are confirmed, the quoters setup will be promoted to production and will start receiving traffic. | |||
|
|
|||
| # (Optional) Signed Order Webhook Notifications | |||
There was a problem hiding this comment.
Why move this back to the quoter section? IMO the order webhook fits better with the filler docs over the quoter docs. The section above it (2A. Retrieve & Execute Signed Dutch Orders) is discussing the alternative approach of calling GET on the endpoint.
codyborn
reviewed
Jun 13, 2024
| GET https://api.uniswap.org/v2/orders?orderStatus=open&chainId=42161&limit=1000 | ||
| ``` | ||
|
|
||
| Use the [UniswapX SDK](https://github.com/Uniswap/sdks/tree/main/sdks/uniswapx-sdk) to parse the `encodedOrder` field returned from endpoint. Each one of these `Orders` represents a fillable user trader. |
There was a problem hiding this comment.
Can you mention that we also support the webhook for Arbitrum orders and link to the Signed Order Webhook Notifications section in the other doc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a specific doc for Arbitrum pilot of UniswapX.