-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update the document deploys to current #683
Merged
Rachel-Eichenberger
merged 4 commits into
main
from
Update-Uniswap-Deployment-Addresses
Apr 10, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the v2router02 contract here for Sepolia is not verified on etherscan, should we try to get that verified before publishing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm also not seeing any transactions there, so just double checking that it's correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior deployed UniswapV2Router02 0x7a250d5630B4cF539739dF2C5dAcb4c659F2488 on Sepolia was verified, but it doesn't have the v2 liquidity support. 0x425141165d3DE9FEC831896C016617a52363b687 was retroactively deployed to Sepolia to support v2 liquidity. Probably the deploy was done in a rush so it was not verified.
I believe this was part of the v2-deploy-everywhere, where UniswapV2Router02 needs to support v2 liquidity as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I think the reason there's no transaction yet is because the PR hasn't merged yet.Uniswap/sdk-core#131
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was newly launched by Emily https://uniswapteam.slack.com/archives/C05MF1J6GR5/p1709845257901909?thread_ts=1708991083.674689&cid=C05MF1J6GR5
The script errored trying to verify the code. Yes, Blast put us behind on pushing the PR.