Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: Corrected typo UNWRAP_ETH -> UNWRAP_WETH #654

Merged
merged 1 commit into from
Feb 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/contracts/universal-router/02-technical-reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ A complete list of commands can be found in the table below:
| `0x09` | [`V2_SWAP_EXACT_OUT`](./02-technical-reference.md#v2_swap_exact_out) |
| `0x0a` | [`PERMIT2_PERMIT`](./02-technical-reference.md#permit2_permit) |
| `0x0b` | [`WRAP_ETH`](./02-technical-reference.md#wrap_eth) |
| `0x0c` | [`UNWRAP_WETH`](./02-technical-reference.md#unwrap_eth) |
| `0x0c` | [`UNWRAP_WETH`](./02-technical-reference.md#unwrap_weth) |
| `0x0d` | [`PERMIT2_TRANSFER_FROM_BATCH`](./02-technical-reference.md#permit2_transfer_from_batch) |
| `0x0e` | |
| `0x0f` | |
Expand Down Expand Up @@ -160,7 +160,7 @@ The individual that signed the permit must be the `msg.sender` of the transactio
- `address` The recipient of the WETH
- `uint256` The amount of ETH to wrap

### `UNWRAP_ETH`
### `UNWRAP_WETH`

- `address` The recipient of the ETH
- `uint256` The minimum required ETH to receive from the unwrapping
Expand Down Expand Up @@ -271,4 +271,4 @@ For a Sudoswap command, that should be *allowed to revert*, the following 8 bit
command = 0x80 (10000000) && 0x19 (00011001) = 0x99 (10011001)
```

Take care when working with reverting commands - ensure you have appended commands to deal with funds that could remain in the contract after either outcomes. For example, if the Sudoswap command reverts, a following `SWEEP` can be added to ensure that any ETH that was not spent does not get left in the router.
Take care when working with reverting commands - ensure you have appended commands to deal with funds that could remain in the contract after either outcomes. For example, if the Sudoswap command reverts, a following `SWEEP` can be added to ensure that any ETH that was not spent does not get left in the router.