audit(14): arbitrum block number #280
Open
+391
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhwu
previously approved these changes
Oct 2, 2024
| } | ||
| } | ||
|
|
||
| contract NonlinearDutchDecayLibTest is Test, GasSnapshot { | ||
| contract NonlinearDutchDecayLibTest is Test, GasSnapshot, BlockNumberish { |
There was a problem hiding this comment.
Wondering if we should do another test suite for chainId 42161 that uses setBlockNumber since our current tests just use vm.roll() which wouldn't do anything in an Arbitrum environment
There was a problem hiding this comment.
Ahh yeah so imo the NonLinearDutchDecayLib should function completely agnostic of the behavior of BlockNumberish - since it strictly takes it in as a parameter. So a test that the blockNumberish parameter passed into the Lib is correctly set may be better in the reactor test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #283