A new round of fixes #227
Closed
A new round of fixes #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter to 'packetSize'"
also: added TODO note
…oncopyable There is no need to copy them in the code, and existing implementation of copying was incomplete. Removed incorrect and unused copy constructor and operator=. Descendant class didn't overrides these.
Base class is already initializing the nodeId_ in the same stage.
… name
par("useAvgInterference") instead of the correct par("computeAvgInterference").
…ction of cComponent Replace otherModule->registerSignal() with (this->)registerSignal() in modules. Replace otherModule->registerSignal() with omnetpp::cComponent::registerSignal() in other classes.
…ists in base class
The module already has the parameter "feedbackGeneratorType", getAncestorPar() found that.
…lity The ip2nic module was overlapped a connection.
…dentical functionality (bodies are equal)
…groundTrafficManager
…le(): already exists in base BackgroundTrafficManager class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.