Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use apt-get to install towncrier #3145

Open
wants to merge 1 commit into
base: 5.11.x
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

This has become necessary due to PEP 668.

Example where currently the towncrier check fails: https://github.com/Uninett/nav/actions/runs/11328705605/job/31502544146?pr=3140

The test workflow is save (for now) since it only runs on Python 3.9 and 3.10.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (a0c30ea) to head (b4e58bd).

Additional details and impacted files
@@           Coverage Diff           @@
##           5.11.x    #3145   +/-   ##
=======================================
  Coverage   60.46%   60.47%           
=======================================
  Files         605      605           
  Lines       43809    43809           
  Branches       48       48           
=======================================
+ Hits        26491    26495    +4     
+ Misses      17306    17302    -4     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland changed the title Fix pip install towncrier by passing break-system-packages flag Use apt-get to install towncrier Oct 16, 2024
Copy link

sonarcloud bot commented Oct 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant