Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhantomJS development has ceased. Our CI test suite currently fails because the outdated version of PhantomJS we're using for the JS tests is trying to use OpenSSL features that are no longer present in more recent versions of OpenSSL:
This PR fixes the problem by temporarily disabling OpenSSL during the running of the test suite on GitHub actions (specifically). The test suite still runs fine on the Docker test image supplied with NAV, since it is based on a slightly older Ubuntu.
For good measure, the PR also updates the workflow to use Node 18, just as the Docker image does.
The future of PhantomJS
We should consider removing PhantomJS from our test suite entirely. It is debatable whether is serves any purpose, since we also test on real JS engines like Firefox and Chrome.