Add check to handle empty form attributes in general non-crispy template #3140
Conversation
If no form.attrs are set then the standard form fields will be rendered. Works as a failsafe.
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 6 files 6 suites 4m 11s ⏱️ For more details on these failures, see this check. Results for commit 02e432c. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3140 +/- ##
=======================================
Coverage 60.44% 60.44%
=======================================
Files 605 605
Lines 43749 43749
Branches 48 48
=======================================
Hits 26443 26443
Misses 17294 17294
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The tests fail since we have not added attrs to the management profile form in #3105.
And generally I thought we were moving away from having the catch-all {{ form }} since we will uncrispify all of nav.
If we don't want to have to add attrs to all forms this tactic is not ideal, since it shows that the tests fail even with the fallback.
Originally mentioned in #3105 (review)
@lunkwill42 har suggested IRL to add the check to the general template.
A general failsafe for #2794