Switch seeddb filter forms to new way of uncrispifying #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
johannaengland
force-pushed
the
refactor/switch-seeddb-filter-form-to-new-way
branch
from
6a733a3
to
b4db6dc
Compare
Test results 8 files 8 suites 8m 14s ⏱️ Results for commit d037671. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3126 +/- ##
==========================================
- Coverage 60.44% 60.44% -0.01%
==========================================
Files 605 605
Lines 43757 43749 -8
Branches 48 48
==========================================
- Hits 26451 26443 -8
Misses 17294 17294
Partials 12 12 ☔ View full report in Codecov by Sentry. |
stveit
approved these changes
Oct 10, 2024
podliashanyk
approved these changes
Oct 11, 2024
johannaengland
force-pushed
the
refactor/switch-seeddb-filter-form-to-new-way
branch
from
ef20131
to
c383bb7
Compare
This was removed when uncrispifying seedDB This adds a new uncrispified version of this method
johannaengland
force-pushed
the
refactor/switch-seeddb-filter-form-to-new-way
branch
from
c383bb7
to
d037671
Compare
|
johannaengland
deleted the
refactor/switch-seeddb-filter-form-to-new-way
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2995.
Reverts things done in #2981 and #3092 (
ManagementProfileFormwill also be changed to useget_single_layoutagain).