Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default if timeout in napalm profile is None #2651

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

johannaengland
Copy link
Contributor

Closes #2645.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #2651 (19f6ec4) into master (28a30bb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2651   +/-   ##
=======================================
  Coverage   54.61%   54.61%           
=======================================
  Files         560      560           
  Lines       40712    40712           
=======================================
  Hits        22235    22235           
  Misses      18477    18477           
Files Changed Coverage Δ
python/nav/napalm.py 76.19% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Test results

     12 files       12 suites   11m 50s ⏱️
3 162 tests 3 162 ✔️ 0 💤 0
8 961 runs  8 961 ✔️ 0 💤 0

Results for commit 19f6ec4.

@johannaengland johannaengland merged commit a84d123 into Uninett:master Aug 10, 2023
11 checks passed
@johannaengland johannaengland deleted the bugfix/napalm-timeout branch August 10, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Empty timeout field causes error when connecting with NAPALM
2 participants