Portadmin poe cisco frontend #2644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let each implementation handle conversion if the actual state is represented as integers or whatever, but for this interface just let it be strings, e.g. DISABLED, AUTO or something
the state options should be the same on the netbox for ports that support it, so no need to check that per interface. what we actually care about is if the interface supports poe, so this does that more explicitly
poe state indexing uses double index of the stack unit number and a interface number. Only place i wasa able to find these nubmers for the interface is in the name, so this is a bit scuffed
|
SonarCloud Quality Gate failed.
|
Codecov Report
@@ Coverage Diff @@
## master #2644 +/- ##
==========================================
+ Coverage 54.20% 54.62% +0.42%
==========================================
Files 558 560 +2
Lines 40634 40782 +148
==========================================
+ Hits 22026 22279 +253
+ Misses 18608 18503 -105
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.