Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring PoE for cisco equipment #2635

Merged
merged 25 commits into from
Nov 15, 2023
Merged

Add support for configuring PoE for cisco equipment #2635

merged 25 commits into from
Nov 15, 2023

Commits on Nov 15, 2023

  1. Add poe related management errors

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    3166e94 View commit details
    Browse the repository at this point in the history

  2. Add mib node and oid for poe in cisco

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    0e67883 View commit details
    Browse the repository at this point in the history

  3. Add poe states for cisco

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    951b601 View commit details
    Browse the repository at this point in the history

  4. Add get_poe_state_options for cisco

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    975fca1 View commit details
    Browse the repository at this point in the history

  5. Add set_poe_state for cisco

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    18e74ee View commit details
    Browse the repository at this point in the history

  6. Add func for getting state of one interface

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7b21cc6 View commit details
    Browse the repository at this point in the history

  7. Add get_poe_states for cisco

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    b3224a6 View commit details
    Browse the repository at this point in the history

  8. Fix typing

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    512f231 View commit details
    Browse the repository at this point in the history

  9. Make fixtures available for all portadmin tests

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e593ea8 View commit details
    Browse the repository at this point in the history

  10. Add tests for cisco poe

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    9b275d3 View commit details
    Browse the repository at this point in the history

  11. Add optional typing to arg

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c3acb34 View commit details
    Browse the repository at this point in the history

  12. Make poe options list static

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    9877059 View commit details
    Browse the repository at this point in the history

  13. Use OID class to put . in front of number

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    bafa79a View commit details
    Browse the repository at this point in the history

  14. Use ifname as key instead of ifindex

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    39debeb View commit details
    Browse the repository at this point in the history

  15. Update tests

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    fb351b5 View commit details
    Browse the repository at this point in the history

  16. Make mocking easier

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    9ea6180 View commit details
    Browse the repository at this point in the history

  17. Add more tests

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    61b2bef View commit details
    Browse the repository at this point in the history

  18. Avoid testing private functions directly

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    dec8a0e View commit details
    Browse the repository at this point in the history

  19. Put test in its own class

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    daf96c6 View commit details
    Browse the repository at this point in the history

  20. Include interface name for mocked interfaces

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    3b11c66 View commit details
    Browse the repository at this point in the history

  21. Add 'self' to func

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    94e769b View commit details
    Browse the repository at this point in the history

  22. Merge function that is only used in other function

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    fd2d9d4 View commit details
    Browse the repository at this point in the history

  23. Avoid mocking private functions 

    mocking is unavoidable here, but can atleast
mock as far away as possible (the manager itself)
    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    8d2abfb View commit details
    Browse the repository at this point in the history

  24. Use 'usefixtures' deco for poeport fixtures 

    these dont have to be accessed in any way in the test,
so its cleaner to activate them through the decorator than
as an argument
    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f6ffc40 View commit details
    Browse the repository at this point in the history

  25. Rename tests

    @stveit
    stveit committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4a8d71d View commit details
    Browse the repository at this point in the history