-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eventengine plugin for juniper alert count #2519
Add eventengine plugin for juniper alert count #2519
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2519 +/- ##
==========================================
- Coverage 54.74% 54.71% -0.03%
==========================================
Files 560 561 +1
Lines 40732 40778 +46
==========================================
+ Hits 22298 22311 +13
- Misses 18434 18467 +33
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f18e8cf
to
b944bab
Compare
44d6783
to
8ae69cf
Compare
a1fafbe
to
02091c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigh codecov is so chatty it's hard to say what's actually going on here. More tests please, just to shut it up. Unless there is a way to hide all the codecov stuff. Anyone? @lunkwill42? Bueller?
More tests are always welcome. As mentioned elsewhere, annotations from CodeCov can be hidden on a file-by-file basis from the "triple dot" menu at the top right of each file header, @hmpf |
172ccc7
to
ad14ebb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe too aggressive logging.
Some questions, which if answered will make it easier to understand what's going on once the code is merged and forgotten. (Without having to understand/remember what eventengine etc. does)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it will pretty much do the trick. Just nitpicks on cleanliness from my side 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
6639689
to
74fc9d1
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Closes #2432