Add connection health check #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcoded value
hmpf
reviewed
Jul 4, 2024
src/howitz/endpoints.py
Outdated
Comment on lines
556
to
572
| @main.route('/test_connection') | ||
| def test_conn(): | ||
| is_connection_ok = test_zino_connection() | ||
| caller_id = request.headers.get('HX-Target', None) | ||
| if not is_connection_ok: | ||
| current_app.logger.debug('Connection test failed showing error appbar') | ||
| return render_template('components/feedback/connection-status-bar/error-appbar-content.html', | ||
| error_message="Connection to Zino server is lost") | ||
| if caller_id == 'connection-error-content': # If connection should be restored after error | ||
| current_app.logger.debug('Connection test OK, caller ID %s', caller_id) | ||
| reconnect_to_zino() | ||
| return render_template('components/feedback/connection-status-bar/success-appbar-content.html') | ||
| else: | ||
| current_app.logger.debug('Connection test OK, caller ID %s', caller_id) | ||
| return render_template('components/feedback/connection-status-bar/success-appbar-content.html') | ||
|
|
||
|
|
There was a problem hiding this comment.
Polish for later: a link zabbix and similar can visit to check health. Need only return http status codes: 200 or 50x.
hmpf
reviewed
Jul 4, 2024
src/howitz/error_handlers.py
Outdated
Comment on lines
115
to
118
| is_connection_ok = test_zino_connection() | ||
| if is_connection_ok is not False: # Both True or None are OK | ||
| reconnect_to_zino() | ||
| short_err_msg = 'Temporarily lost connection to Zino server, please retry your action' |
There was a problem hiding this comment.
Uuuh.. reconnect if the connection is ok? Did you mean if is_connection_ok is False:?
There was a problem hiding this comment.
This is deliberate. This code is in handle_lost_connection, so the connection was down when it was called. Here we check if connection is back again. reconnect_to_zino means "ensure a clean reconnect procedure", I will add some comments with explanations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145