Fix stale columns data #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a helper where implementation is copied from curitz. Formatting downtime info in the column this way removes the stale-data-problem for this column completely. This is because there are no more redundant time units (that need constant updates) that are shown in the column, so whenever downtime for event is changed this info is updated in the specific row via NTIE.
This timestamp is updated only if all events attributes and computed fields were actively refreshed using create_table_event()
No zinolib is called, just recalculation of event internal data
hmpf
reviewed
Jun 19, 2024
Comment on lines
+80
to
+82
| age = datetime.now(timezone.utc) - opened | ||
| age_formatted = str(age)[:-10] | ||
| return age_formatted |
There was a problem hiding this comment.
It's soo tempting making a "tznow" utils-function for datetime.now(timezone.utc).
hmpf
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97