Improve app settings #906
Open
Improve app settings #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmpf
added
documentation
elfjes
approved these changes
Oct 14, 2024
.. and due to this, move the overriding to the end of base settings
.. this makes it easy to change settings that are not app-specific, like LOGIN_URL.
.. make sure the examples are valid JSON
hmpf
force-pushed
the
improve-app-settings
branch
from
b8a242e
to
823fd92
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new frontend needs different simple settings (like LOGIN_URL) from the old frontend so we need to support that.
We can piggy-back on the (EXTRA|OVERRIDING)_APPS to do this but geant prefers vanilla settings files.
This is an attempt at having our cake and eating it too. Reusing the (EXTRA|OVERRIDING)_APPS-machinery and still making it easy to override everything with separate settings-files.
(This is not the final step in the journey, just an easily reviewable one.)