Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up OAuth2 helper functions #898

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Clean up OAuth2 helper functions #898

merged 3 commits into from
Oct 9, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Oct 9, 2024

Depends on #894

This is step one in a multistep operation. See #862

@hmpf hmpf added priority: high auth Touches the authentication/authorization subsystem META I contain multitudes HTMx Views, urls, templates... new setting Needs a new setting in settings.py, possibly with validator labels Oct 9, 2024
@hmpf hmpf requested review from a team October 9, 2024 06:43
@hmpf hmpf self-assigned this Oct 9, 2024
@hmpf hmpf added the blocked Another thing/issue has to be resolved before tackling this label Oct 9, 2024
@elfjes
Copy link
Collaborator

elfjes commented Oct 9, 2024

Why would there need to be an (optional) dependency on argus-htmx?

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.15%. Comparing base (140d45a) to head (0334b40).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/argus/auth/utils.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   84.18%   84.15%   -0.03%     
==========================================
  Files          90       90              
  Lines        4065     4065              
==========================================
- Hits         3422     3421       -1     
- Misses        643      644       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf hmpf removed META I contain multitudes HTMx Views, urls, templates... labels Oct 9, 2024
@hmpf
Copy link
Contributor Author

hmpf commented Oct 9, 2024

Because the switcher imports things from argus_htmx.

I was thinking "pip install argus-server[htmx-frontend]".

Copy link

sonarcloud bot commented Oct 9, 2024

@hmpf hmpf merged commit 537afc4 into Uninett:master Oct 9, 2024
9 checks passed
@hmpf hmpf deleted the oauth2 branch October 9, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Touches the authentication/authorization subsystem blocked Another thing/issue has to be resolved before tackling this new setting Needs a new setting in settings.py, possibly with validator priority: high
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants