Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 with ruff #869

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Aug 30, 2024

Dependent on #868.

@johannaengland johannaengland added the blocked Another thing/issue has to be resolved before tackling this label Aug 30, 2024
@johannaengland johannaengland self-assigned this Aug 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.25%. Comparing base (4f8776e) to head (115d641).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/argus/notificationprofile/media/email.py 0.00% 1 Missing ⚠️
...rc/argus/notificationprofile/media/sms_as_email.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
- Coverage   84.29%   84.25%   -0.05%     
==========================================
  Files          86       86              
  Lines        3973     3950      -23     
==========================================
- Hits         3349     3328      -21     
+ Misses        624      622       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 30, 2024

Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this into several PR's?

One that:

  1. changes everything that must be able to run locally first ("ruff format" instead of black in pre-commit)
  2. then one that "ruff format"s all code

Then we'll need to directly push a revision to ignore blames for.

Then, we can replace flake8 with ruff for the "critical" stuff in pre-commit and tox and github actions in a new PR.

Finally, we can argue if we want to lint everything via pre-commit/tox/github actions and how many reviews that would take.

If we use ruff directly to lint, will we need Megalinter at all?

@johannaengland
Copy link
Contributor Author

johannaengland commented Oct 9, 2024

If we use ruff directly to lint, will we need Megalinter at all?

No, we won't. At least not when we have also switched to ruff for formatting.

@johannaengland
Copy link
Contributor Author

This PR will be split into multiple smaller PRs and needs to be strongly rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Another thing/issue has to be resolved before tackling this
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants