Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linting workflow #810

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Update linting workflow #810

merged 8 commits into from
Nov 5, 2024

Conversation

dopplershift
Copy link
Member

Description Of Changes

  • Switch over to ruff for most of linting (matching MetPy)
  • Migrate most of config over to pyproject.toml
  • Add codespell to tools

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 4, 2024
View reviewed changes
src/siphon/http_util.py
@@ -9,12 +9,8 @@
from io import BytesIO
from itertools import chain
import posixpath
from urllib.parse import urlencode, urljoin # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'urljoin' is not used.
@dopplershift dopplershift marked this pull request as ready for review November 4, 2024 21:43
dcamron
dcamron reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like developerguide.rst needs a few more updates than just those included here. We can open a separate issue for that though.

@dcamron dcamron merged commit fdc7f3b into Unidata:main Nov 5, 2024
27 checks passed
@dopplershift dopplershift deleted the update-linting branch November 5, 2024 19:13
@github-actions github-actions bot added this to the 0.10 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcamron dcamron dcamron approved these changes

@lesserwhirls lesserwhirls Awaiting requested review from lesserwhirls lesserwhirls is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
2 participants
@dopplershift @dcamron