Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add cumulative integration function. #3508

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

ENH: Add cumulative integration function. #3508

wants to merge 31 commits into from

Commits on May 21, 2024

  1. ENH: Add cumulative integration function.

    @DWesl
    DWesl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4151d1c View commit details
    Browse the repository at this point in the history

  2. STY: Ensure two blank lines between test functions.

    @DWesl
    DWesl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    115415d View commit details
    Browse the repository at this point in the history

  3. BUG,STY: Fix NameError in test 

    That's what I get for not paying attention when borrowing implementation while changing names.

Also fix some lint errors.
    @DWesl
    DWesl authored May 21, 2024
    Configuration menu
    Copy the full SHA
    9ca6384 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. TST: Expand cumulative_integrate tests.

    @DWesl
    DWesl committed May 23, 2024
    Configuration menu
    Copy the full SHA
    9d9dd0d View commit details
    Browse the repository at this point in the history

  2. STY: Change double quotes to single. 

    Docstrings are double quotes in the rest of the file.
    @DWesl
    DWesl committed May 23, 2024
    Configuration menu
    Copy the full SHA
    8ab2549 View commit details
    Browse the repository at this point in the history

  3. BUG: Fix cumulative_integrate axis handling.

    @DWesl
    DWesl committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6c1f2a7 View commit details
    Browse the repository at this point in the history

  4. TST,BUG: Fix 2D XArray test for cumulative_integral

    @DWesl
    DWesl authored May 23, 2024
    Configuration menu
    Copy the full SHA
    27f9fc5 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. BUG: Fix syntax error in units check

    @DWesl
    DWesl authored May 24, 2024
    Configuration menu
    Copy the full SHA
    08ed4ea View commit details
    Browse the repository at this point in the history

  2. STY: wrap lines and fix tests.

    @DWesl
    DWesl committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6ae4f66 View commit details
    Browse the repository at this point in the history

  3. TST: Fix test mismatches.

    @DWesl
    DWesl committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f5bf47b View commit details
    Browse the repository at this point in the history

  4. STY: Sort import ordering.

    @DWesl
    DWesl committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c996909 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. DOC: Add cumulative_integrate to metpy.calc Mathematical Funtions list.

    @DWesl
    DWesl committed May 26, 2024
    Configuration menu
    Copy the full SHA
    cf5951d View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. ENH: Switch to using scipy.integrate.cumulative_trapezoid for calcula… 

    …tions.

I might need to pull out the derivation of x when I add integrate.
    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    4af2eb1 View commit details
    Browse the repository at this point in the history

  2. FIX: Pass magnitudes to unit-unaware functions.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5eb45cc View commit details
    Browse the repository at this point in the history

  3. TST: Fix unit handling.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    609c44a View commit details
    Browse the repository at this point in the history

  4. TST: Fix unit tests.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3b6ac91 View commit details
    Browse the repository at this point in the history

  5. TST,FIX: Fix units in test, the right way this time.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c15f4bb View commit details
    Browse the repository at this point in the history

  6. BUG: Add back-up for unitless arguments. 

    Possibly avoidable, given cumulative_trapezoid already handles that case.
Should I raise a ValueError to add units or re-direct to cumulative_trapezoid?
    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    480d5d1 View commit details
    Browse the repository at this point in the history

  7. Stop trying to handle unitless NumPy arrays. 

    scipy.integrate.cumulative_integrate already handles them.
    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c7e721e View commit details
    Browse the repository at this point in the history

  8. STY: Drop assignment to unused variable

    @DWesl
    DWesl authored May 27, 2024
    Configuration menu
    Copy the full SHA
    25f6bf1 View commit details
    Browse the repository at this point in the history

  9. TST,BUG: Fix pytest.raises decorator

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    2388547 View commit details
    Browse the repository at this point in the history

  10. TST,BUG: Fix type of error in test.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0935278 View commit details
    Browse the repository at this point in the history

  11. BUG: Fix exception type to match test.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    1b5d30b View commit details
    Browse the repository at this point in the history

  12. DOC: Fix example for cumulative_integrate.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    a5d95e4 View commit details
    Browse the repository at this point in the history

  13. DOC,FIX: Fix example output formatting.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    40a7386 View commit details
    Browse the repository at this point in the history

  14. DOC,FIX: Import XArray for that example.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    a9de575 View commit details
    Browse the repository at this point in the history

  15. DOC,FIX: Fix call to cumulative_integrate.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    4d0379b View commit details
    Browse the repository at this point in the history

  16. Use units for delta, not x, for finding final units.

    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    b51682b View commit details
    Browse the repository at this point in the history

  17. DOC: Remove example with results differing by OS. 

    Windows is fine with commas,
Mac wants decimal points and skips the commas.
    @DWesl
    DWesl committed May 27, 2024
    Configuration menu
    Copy the full SHA
    9b82a80 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. STY: Fix ruff errors.

    @DWesl
    DWesl committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5a663e1 View commit details
    Browse the repository at this point in the history

  2. STY: Fix flake8 errors.

    @DWesl
    DWesl committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5d72db3 View commit details
    Browse the repository at this point in the history