Make coordinate detection more robust #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around an issue where some ERA5 data had lat/lon with a "positive" attribute that, according to the CF specification, should indicate a vertical coordinate. We can fix this up by making sure each coordinate variable is only associated with a single option, and making use of Python's key-ordered dictionaries to prioritize the matching order. Having lat be y and lon be x is already handled by a later block.
dopplershift
added
Type: Enhancement
dcamron
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This works around an issue where some ERA5 data had lat/lon with a "positive" attribute that, according to the CF specification, should indicate a vertical coordinate. We can fix this up by making sure each coordinate variable is only associated with a single option, and making use of Python's key-ordered dictionaries to prioritize the matching order. Having lat be y and lon be x is already handled by a later block.
Checklist