Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First working version of the framework. Btag sfs are disabled #1

Open
wants to merge 2 commits into
base: 80X
Choose a base branch
from

Conversation

vischia
Copy link
Member

@vischia vischia commented Jan 11, 2017

Merging Sergio development branch

@@ -0,0 +1,230 @@
import os
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sscruz the idea was to have it in the susyMaintenance stuff, but for me it can be left here without any problem.

Perhaps let's ping @nachosandres , since he wrote the bulk of the script.


batch = True
queue = "batch" #"batch" for Oviedo, "8nh" or others for lxplus
path = "/mnt_pool/fanae105/user/sscruz/TTH/samples"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add it to this main repo, we should clean it up quite heavily, in order not to have (too many) hardcoded paths and such

@sscruz @nachosandres

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitely keep this script out of the repo (personally, I never add it to my commits), since it works by hardcoding your path (user specific), friend tree module (analysis specific) and accepted/excluded samples (both), all of which one changes again and again when running. It's only an unnecessary source of changes in our commit history.

@@ -1,18 +1,18 @@
ttH+ : TTHnobb_mWCutfix_ch0 : 0.5071*0.418 : LepGood1_isMatchRightCharge && LepGood2_isMatchRightCharge; FillColor=ROOT.kOrange+10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure these commented lines does not mess up things for other people? Perhaps we should have a different mca, for the moment, or use the one used by everyone?

@sscruz

@@ -11,17 +11,19 @@

def base(selection):

CORE="--Fs {P}/2_recleaner_v5_b1E2 --Fs {P}/4_kinMVA_without_MEM_v5 --Fs {P}/8_bTagSF_12fb_v45"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment here. Perhaps here we could have the thing used by the other people as default, and add a command line option such as --env oviedo (default "" or "cern") that sets our personalized stuff instead

@sscruz

if dowhat == "plots": GO+=" ttH-multilepton/2lss_3l_plots.txt --xP '^lep(3|4)_.*' --xP '^(3|4)lep_.*' --xP 'kinMVA_3l_.*' "
elif selection=='3l':
GO="%s -P /data1/peruzzi/mixture_jecv6prompt_datafull_jul20_skimOnlyMC ttH-multilepton/mca-3l-mc.txt ttH-multilepton/3l_tight.txt "%CORE
GO="%s -P /nfs/fanae/user/sscruz/TTH/samples/leptonJetReCleanerTTH/ ttH-multilepton/mca-3l-mc.txt ttH-multilepton/3l_tight.txt "%CORE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see, there are already hardcoded paths, but we should follow the virtuous path 😛

@sscruz

@@ -59,7 +61,6 @@ def doprescale3l(x):
torun = sys.argv[2]

if (not allow_unblinding) and '_data' in torun and (not any([re.match(x.strip()+'$',torun) for x in ['.*_appl.*','cr_.*']])): raise RuntimeError, 'You are trying to unblind!'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid newlines addition/removal, unless strictly necessary @sscruz

@@ -249,3 +250,5 @@ def doprescale3l(x):
runIt(x,'%s'%torun,plots)
x = add(x,"-E ^4j ")
runIt(x,'%s_4j'%torun,plots)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid newlines addition/removal, unless strictly necessary @sscruz
@sscruz

@@ -249,3 +250,5 @@ def doprescale3l(x):
runIt(x,'%s'%torun,plots)
x = add(x,"-E ^4j ")
runIt(x,'%s_4j'%torun,plots)

print torun
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a debug line, that is not necessary to push to production @sscruz

@@ -21,9 +21,9 @@
#--- Recleaner instances
from CMGTools.TTHAnalysis.tools.leptonChoiceRA5 import _susy2lss_lepId_CBloose,_susy2lss_lepId_loosestFO,_susy2lss_lepId_IPcuts,_susy2lss_lepConePt1015,_susy2lss_lepId_tighterFO,_susy2lss_multiIso,_susy2lss_lepId_CB,_susy2lss_idIsoEmu_cuts
from CMGTools.TTHAnalysis.tools.leptonChoiceRA7 import _susy3l_lepId_CBloose, _susy3l_lepId_loosestFO,_susy3l_lepId_loosestFO,_susy3l_multiIso,_susy3l_lepId_CB
from CMGTools.TTHAnalysis.tools.leptonBuilderEWK import _susyEWK_lepId_CBloose, _susyEWK_lepId_IPcuts, _susyEWK_lepId_MVAFO, _susyEWK_lepId_MVAmedium, _susyEWK_tauId_CBloose, _susyEWK_tauId_CBtight
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break things for other people? --env oviedo here as well, perhaps?

@sscruz

@@ -65,67 +65,67 @@


# MVA (upper limits and combination)
MODULES.append( ('leptonJetReCleanerSusyEWK3L', lambda : LeptonJetReCleaner("Mini",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, what is this massive substitution? @sscruz

Copy link
Member Author

@vischia vischia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sergio, I did add a few notes on the commits, that should probably looked into

🎉

Pietro

cericeci pushed a commit that referenced this pull request Sep 20, 2019
Keeping up-to-date with central
cericeci pushed a commit that referenced this pull request Sep 20, 2019
cericeci pushed a commit that referenced this pull request Sep 20, 2019
cericeci pushed a commit that referenced this pull request Sep 20, 2019
cericeci pushed a commit that referenced this pull request Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants