Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport along and action on equivalences #706

Merged
merged 51 commits into from
Sep 11, 2023

Conversation

fredrik-bakke
Copy link
Collaborator

@fredrik-bakke fredrik-bakke commented Aug 23, 2023

Summary

  • Define transport along equivalences tr-equiv in foundation.transport-along-equvalences using transport along identifications
  • Define action on equivalences ap-equiv in foundation.action-on-equivalences-functions using action on identifications
  • Show that these notions coincide
  • Prove a collection of basic properties for each
  • Do some refactoring surrounding this

@fredrik-bakke
Copy link
Collaborator Author

fredrik-bakke commented Aug 23, 2023

Should the module* transport be renamed to transport-along-identifications?

@morphismz
Copy link
Contributor

Should transport be renamed to transport-along-identifications?

this could be helpful. Then you could rename your tr-equiv to transport-along-equiv. This will help disambiguate the latter from equiv-tr.

@morphismz
Copy link
Contributor

Since this is a draft, does this mean you have plans to add a few more definitions and lemmas? I can think of a few that would be nice to have but I can't find in this pr

@fredrik-bakke
Copy link
Collaborator Author

Yes, I'm planning to add a couple more.

@fredrik-bakke
Copy link
Collaborator Author

Should transport be renamed to transport-along-identifications?

this could be helpful. Then you could rename your tr-equiv to transport-along-equiv. This will help disambiguate the latter from equiv-tr.

I like the name tr-equiv. Hopefully the similar naming won't cause too much confusion.

@morphismz
Copy link
Contributor

Should transport be renamed to transport-along-identifications?

this could be helpful. Then you could rename your tr-equiv to transport-along-equiv. This will help disambiguate the latter from equiv-tr.

I like the name tr-equiv. Hopefully the similar naming won't cause too much confusion.

fair enough. Then, may I ask, why rename transport to transport-along-identifications?

@fredrik-bakke
Copy link
Collaborator Author

Should transport be renamed to transport-along-identifications?

this could be helpful. Then you could rename your tr-equiv to transport-along-equiv. This will help disambiguate the latter from equiv-tr.

I like the name tr-equiv. Hopefully the similar naming won't cause too much confusion.

fair enough. Then, may I ask, why rename transport to transport-along-identifications?

Ah, I think I see your confusion! I was talking about the module names, so that we have transport-along-identifications in line with transport-along-equivalences and similar for actions.

@morphismz
Copy link
Contributor

Should transport be renamed to transport-along-identifications?

this could be helpful. Then you could rename your tr-equiv to transport-along-equiv. This will help disambiguate the latter from equiv-tr.

I like the name tr-equiv. Hopefully the similar naming won't cause too much confusion.

fair enough. Then, may I ask, why rename transport to transport-along-identifications?

Ah, I think I see your confusion! I was talking about the module names, so that we have transport-along-identifications in line with transport-along-equivalences and similar for actions.

Gotcha, that makes much more sense! I'm on board

@EgbertRijke
Copy link
Collaborator

I think it's a good idea to rename the transport module to transport-along-identifications

@fredrik-bakke
Copy link
Collaborator Author

So... I just realized that foundation.univalence-action-on-equivalences exists...

@fredrik-bakke
Copy link
Collaborator Author

I'll try and merge the two modules. Which name do you prefer?

@EgbertRijke
Copy link
Collaborator

transport-along-equivalences sounds better to me than univalence-action-on-equivalences

@fredrik-bakke fredrik-bakke changed the title Action on equivalences and transport along equivalences Transport along and action on equivalences Aug 23, 2023
@EgbertRijke
Copy link
Collaborator

EgbertRijke commented Sep 11, 2023

Alright, I am done reviewing. I would like to propose an alternative naming scheme for the ap-equiv naming scheme. I am ok with the tr-equiv naming scheme, but what I don't like about ap-equiv is that in the agda-unimath naming scheme it reads too much like the action on paths of an equivalence, which it isn't. So I would really like to convince you that action-equiv is better. Here is what I propose:

eq-ap-equiv -> action-equiv-function
ap-equiv -> action-equiv-family
map-ap-equiv -> map-action-equiv-family
ap-equiv-subuniverse -> action-equiv-family-on-subuniverse

and so on. I think the preposition on is necessary in this case, to disambiguate from families of types in a subuniverse.

Another possibility for the last one, is action-equiv-subuniverse-family, because we are already using the naming scheme equiv-subuniverse for equivalences in a subuniverse.

@EgbertRijke
Copy link
Collaborator

Perhaps I would also like to propose to rename ap to action-eq, but that will be for another day:)

@fredrik-bakke
Copy link
Collaborator Author

As a counter-proposal, we could switch the phrasing "action on identifications" to "application to identifications"

@fredrik-bakke
Copy link
Collaborator Author

I do like the new names you've suggested for the action on equivalences though. Thank you for that

@EgbertRijke
Copy link
Collaborator

The transport -> transport-along-identifications renaming looks good too. It was indeed easy to scroll through the separate commit. Thank you for separating this out.

@EgbertRijke
Copy link
Collaborator

Can I merge it?

@fredrik-bakke
Copy link
Collaborator Author

I think so :)

@EgbertRijke EgbertRijke merged commit a0c49ae into UniMath:master Sep 11, 2023
4 checks passed
@EgbertRijke
Copy link
Collaborator

Thanks for all the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants