Use $HOME rather than /home/pi #4152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's an issue with the changes to the script. Though you're using the $HOME for all the hardcoded paths, for the changes to the sudoers file, you're still using "pi". In the context of changing to using $HOME, this is wrong. You should also use $USER. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install.shassumes that the old default username ofpiis in use. Now that OctoPi is in the Raspberry Pi Imager, it's fairly likely that the username will be customized, andinstall.shwill prompt with "Neither /home/pi/OctoPrint/venv nor /home/pi/oprint can be found."Using
$HOMEinstead of hard-coding/home/pifixes this.