Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get chamber temperture on main screen without plugins #3654

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Ybalrid
Copy link

@Ybalrid Ybalrid commented May 18, 2023

Hello 👋

First time contributing to this project (and touching TypeScript).

See discussion in #2562

This changeset displays a printer's chamber temperature without requiring the Enclosure plugin's usage.

This is achieved using the standard OctoPrint feature for printers that reports chamber temperatures with a readout called "C" (alongside "T" and "B").

  • A Chamber temperature is added to the PrinterStatus model
  • When receiving printer data from the WebSocket, it is added to the PrinterStatus message if a current chamber temperature is found.
  • If the bottom bar component does not find an Enclosure configuration but can find a chamber temperature readout, it will be set as the enclosure chamber temperature and displayed on the screen. The temperature is displayed in the HTML element already set up for the enclosure plugin.

@Ybalrid
Copy link
Author

Ybalrid commented May 21, 2023

This now shows the chamber temperature directly from Octoprint in the bottom bar, where the Enclosure plugin also shows the temperature.

Note: This currently may conflict with the enclosure plugin. Needs testing.

image

@Ybalrid Ybalrid marked this pull request as ready for review May 24, 2023 16:43
@Ybalrid Ybalrid changed the title WIP: Get chamber temperture on main screen without plugins Get chamber temperture on main screen without plugins May 24, 2023
@Ybalrid
Copy link
Author

Ybalrid commented Jun 5, 2023

@UnchartedBull any chance you can take look into this ? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant