Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintegrate Melody Mania up to 2024-10-06 #473

Merged
merged 12 commits into from
Oct 14, 2024

Conversation

achimmihca
Copy link
Collaborator

@achimmihca achimmihca commented Oct 7, 2024

What does this PR do?

Reintegrate recent changes from Melody Mania.

Closes Issue(s)

close #465
close #464
close #435
close #420

Motivation

  • prepare contributions to UltraStar Play by new developer

@achimmihca
Copy link
Collaborator Author

The pipeline is not working because Unity does not seem to accept the license (same old, same old).

Documentation how to set up the license with the GitHub Actions can be found here: https://game.ci/docs/github/activation

Unfortunately, the instructions do not work. All secrets are in place, but the error remains.

Visit https://game.ci/docs/github/activation for more
details on how to set up one of the possible activation strategies.
Error: No valid license activation strategy could be determined. Make sure to provide UNITY_EMAIL, UNITY_PASSWORD, and either a UNITY_SERIAL or UNITY_LICENSE. Otherwise please use UNITY_LICENSING_SERVER.
Error: The process '/usr/bin/docker' failed with exit code 1

But UNITY_EMAIL, UNITY_PASSWORD, and UNITY_LICENSE have been set already.

It seems there are also others with this issue.
Unity seems to have changed the way how to activate a personal license.

Before, GameCI had an action to aquire a license request ( https://github.com/marketplace/actions/unity-request-activation-file ). But this is now deprecated

Please follow the updated activation steps for v4 and newer of Unity Actions.

But as I said, the instructions do not work.

I don't know how to proceed here.
Maybe asking the game-ci folks on Discord may help.

@basisbit
Copy link
Member

basisbit commented Oct 8, 2024

How I previously always got it to work: run the thing locally in a docker container, activate it, get the activation license file content, write that content into a github secret. and have the docker container write that secret into the required license file

@achimmihca
Copy link
Collaborator Author

Nevermind, I forgot to expose the new secrets UNITY_EMAIL and UNITY_PASSWORD to the GitHub Actions workflows.

Unity is building the project now, but it seems there are some issues. Will take a look soon.

@basisbit basisbit marked this pull request as ready for review October 14, 2024 17:12
@basisbit
Copy link
Member

For Ansis to be able to continue working, we decided to ignore the buidl pipeline requirement for now and merge anyways. Hope this is okay for you.

Copy link
Member

@basisbit basisbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@basisbit basisbit merged commit 4d56d5b into master Oct 14, 2024
0 of 7 checks passed
@basisbit basisbit deleted the anst/reintegrate-melodymania-2024-10-06 branch October 14, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants