Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply support 3MF Production Extension. #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cmguo
Copy link

@cmguo cmguo commented Jun 16, 2023

This patch adds simple support for [3MF Production Extension]https://github.com/3MFConsortium/spec_production/blob/master/3MF%20Production%20Extension.md).

I use an implicit method to extend the function instead of modifying the py interface.
This method prepends the "path" to the xml content and passes them together to ThreeMFParser::parse.

The parse method works with a single scene until it reaches the root model. The single scene is a static C++ instance, because I can't add members to the class ThreeMFParser , that would break the consistency with the pySavitar library.

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Jun 16, 2023
@cmguo
Copy link
Author

cmguo commented Jun 16, 2023

The unit-test fail is not relate to source code.

Notice: A new release of pip is available: 23.0.1 -> 23.1.2
Notice: To update, run: pip install --upgrade pip
usage: conan profile [-h] [-v [V]] {detect,list,path,show} ...
conan profile: error: argument subcommand: invalid choice: 'new' (choose from 'detect', 'list', 'path', 'show')
ERROR: Exiting with code: 2
Error: Process completed with exit code 2.
0s

@rburema
Copy link
Member

rburema commented Mar 20, 2024

A unit-test fix was just committed to main, should work again.

We're (or rather, my colleagues) are working to clean up our PR backlog, so hopefully the wait (at least for go/no-go) won't be that much longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants