Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CuraApplication.py add startReloadAll signal when reloadAll is called #19608

Open
wants to merge 4 commits into
base: 5.8
Choose a base branch
from

Commits on Aug 31, 2024

  1. Fix RecentFilesMenu.qml onObjectRemoved incompatible arguments

    "share/cura/resources/qml/Menus/RecentFilesMenu.qml:39:
    TypeError: Passing incompatible arguments to C++ functions from JavaScript is not allowed."
    
    This was passing the Instantiator index, which is a Number to menu.removeItem
    which is expecting an object.  Add the missing index argument.  I
    found Qt 5.7 had two arguments so it has been there for some time.
    dfries committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    2749de9 View commit details
    Browse the repository at this point in the history
  2. Fix RecommendedSupportSelector.qml assign undefined to int

    share/cura/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml:60:17:
    Unable to assign [undefined] to int
    
    If undefined use Widgets/SingleSettingComboBox.qml
    default of Cura.ExtruderManager.activeExtruderIndex
    dfries committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    38695d9 View commit details
    Browse the repository at this point in the history
  3. Use raw strings for regular expressions with invalid escape sequences

    If "T(\d*)" was "T(\n*)" it would search for newlines.  There isn't
    any such \d escape character.
    
    It should be "T(\\d*)" or r"T(\d*)" going with the latter, to be
    easier to read and be consistent with other Cura usage.
    
    Start python with -Wd or for python 3.12 will raise a SyntaxWarning.
    dfries committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    6e3e3e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Add startReloadAll signal when reloadAll is called

    Uranium/UM/Scene/Scene.py depends this startReloadAll, which it will
    use to cancel file modification reload dialog.  Once all the models
    are reloaded, the file modification reload is not needed.
    dfries committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    be0a000 View commit details
    Browse the repository at this point in the history