Add definitions and profiles to ZYYX+, ZYYX Pro and ZYYX Pro ii #18374
Conversation
github-actions
bot
added
the
PR: Community Contribution 👑
|
Note: this PR references some materials not yet implemented in Cura. These materials are currently awating approval in PR#281 in Ultimaker/fdm_materials. |
saumyaj3
added
the
PR: Printer Definitions 🏭
|
Error Files:
|
|
@wawanbreton It's removed, but the bot complains... |
|
Indeed 😅 I'll see with the team how to handle this properly |
|
So, the consequences of removing the printer definition are the following:
The very proper way to handle this situation would have been to create an upgrade script, and convert the printers and project files using Agile to now using Pro, which is what actually happened. However, this is much more complex, so if we assume nobody in the world (except maybe a few engineers at ZYYX) have used this printer, we can safely ignore this warning. Do you think it would be worth contacting them again to check, or can we safely remove it, knowing the consequences ? |
|
My view is that very few people use the printer and it would therefore not be worth writing an upgrade script. The ZYYX Pro was released in 2017, so I doubt that even the engineers at ZYYX are still using the "Agile". Furthermore, up until this PR I believe that most users used Simplyfy3D instead of Cura. |
|
Or we could just leave it in 🤷 |
|
Ok, looks like they just made a test with Cura, that ended up in the mainstream for weak reasons. I'm good with removing it then. If people somehow get to complain about this, they can still restore the files on their installation, and we shall put it back, but that is extremely unlikely. |
|
Error Files:
|
|
@wawanbreton Versions updated and line_width removed! |
|
Nice, thanks ! I just saw that some variants defined a line_width different from the machine_nozzle_size tough, those should probably be restored ? Also there are some conflicts with main, because we just upgraded the settings_version to 24 (didn't think we would merge it that fast 😀) so you can ignore the conflicts and force your files removals. |
|
It appears I accidentally put weird values for line_width for the 0.8mm (and 0.2mm) nozzle. I believe the default should perform better. Should I bump the settings version to 24? |
As you are on it, you can. Otherwise we plan to make an other pass for it. |
|
I have not checked v.24 compatibility, maybe I/we could do it in the future. |
|
changes between 23 and 24 are really self-contained and don't concern your settings at all, so you can safely put either 23 or 24 |
|
Then 23 is ok by me. |
|
Hi @theodorhansson, can you just fix the git conflicts ? After that I guess we can merge this PR |
# Conflicts: # resources/quality/zyyx/zyyx_agile_global_fast.inst.cfg # resources/quality/zyyx/zyyx_agile_global_fine.inst.cfg # resources/quality/zyyx/zyyx_agile_global_normal.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_flex_fast.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_flex_fine.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_flex_normal.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_pla_fast.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_pla_fine.inst.cfg
|
Error Files:
|
|
@wawanbreton I merged the branches (and updated to v24...). |
|
Very nice, thanks ! I can now approve and it will be merged after further testing. |
|
Error Files:
|
Description
This adds three printers that were previously missing from Cura.
This also changes the manufacturer of the following printer. Which was previously made by Magicfirm Europe, but the firm was rebranded to ZYYX Labs AB.
Type of change
Implements
How Has This Been Tested?
Testprints have been performed on all ZYYX printers except ZYYX Agile.
Test Configuration:
Checklist: