CURA-10951 build plugin as bundled plugin on the GH runners #16607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Gradual Accel Change. Update LimitXYAccelJerk.py Round the Accel numbers to nearest "50". Create LimitXYAccelJerk.py New post processor to limit the X and or Y accel and jerk for bed-slinger printers. Update LimitXYAccelJerk.py Removed debug code. Update LimitXYAccelJerk.py Remove debug code Update LimitXYAccelJerk.py Bug Fix
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Contributes to CURA-8415
Added a conditional statement for optionally triggering nightly releases in the installer workflow. This change allows us to initiate automatic nightly builds only when required, contributing to efficiency and resource utilization optimization. This is linked to Jira task CURA-9494.
Add Exit for Ultimaker printers. Add notice that Accel is not-extruder specific. Changed variable names to lower case.
# Conflicts: # .github/workflows/installers.yml # .github/workflows/macos.yml # .github/workflows/windows.yml
A daily schedule for the update-nightly-release workflow was added. Now, apart from when the 'nightly' input is set to true, the release update will be triggered everyday at 5:20 CET. This functionality allows more up to date releases without manual input. Also, installer file names were updated and it now includes the daily creation timestamp which provides visibility on when the nightly build was generated. Contributes to CURA-9494
Contributes to CURA-9494
Contributes to CURA-9494
Contributes to CURA-9494
Only shown in builds, for alpha versions Contributes to CURA-9494
Contributes CURA-10466
Contributes to CURA-10951 and CURA-10446
…curapackage # Conflicts: # .github/workflows/requirements-conan-package.txt # conanfile.py
This will be deprecated, since we are also using self.dependencies we should do this in the generate. Contributes to CURA-10951
Changes made per Rburema requests.
Contributes to CURA-10951
…urapackage # Conflicts: # conanfile.py
Contributes to CURA-10951
Contributes CURA-10951
Contributes CURA-10951
Contributes CURA-10951
Contributes CURA-10951
Allow objects to be placed near border for grid arrange
still ship other executables Contributes to CURA-10951
Issue before was the following: when placing objects within a grid cell there is a margin around the object. This margin comes from both the integer rounding of the cell and the defined min distance between objects. When trying to place object near the buildplate border we marked any cell that is not fully within the buildplate area as an invalid cell to place objects in. This was however too strict; there is the aforementioned margin around the object, and if only this margin would be outside the buildplate it is perfectly fine to place object in that cell. CURA-7951
Create LimitXYAccelJerk.py
part of CURA-10942
2 tasks
rburema
approved these changes
Sep 8, 2023
| os.path.join("..", "icons", "cura-icon_256x256.png"): "cura-icon.png", | ||
| } | ||
|
|
||
| # TODO: openssl.cnf ??? |
There was a problem hiding this comment.
Need to double check, if you can overload the openssl config. But we weren't doing that before, since that file doesn't exist.
I think it only be an issue on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the gradual flow plugin as a bundled plugin:
Needed to build the AppImage on a modern Ubuntu version again for this. Because the Gradual flow plugin is now build using the same dependency versions and options as Cura/CuraEngine.
GCC-13 and statical compiling on glibc<2.34 doesn't play nice. Switched to AppImage Builder, which will also copy the glibc from the system it was compiled. This means that we can run it from Ubuntu 18.04 again. I also made sure that the list of system packages, such as the ones needed for system file dialogs have been packed in the AppImage. All of these measurements should improve portability on different Linux Distro's. I tested it on Manjaro (KDE X11 and Wayland), Ubuntu 20.04 (Gnome X11) running in a virtualbox, Ubuntu 22.04 (Gnome X11, KDE both Wayland and Gnome).
The plugin is packaged and installed from the specified pyinstaller mappings in the conandata.yml.
Most of the changes in Savitar, nest2d, Arcus relate to update the way that the package and build with Conan and our custom SIP and pyprojecttoolchains. Since I needed generate the C++ headers and source files with SIP in a different folder, because conan <= 1.57 didn't create the build folder before the sip-build was run, but the newer versions do. Which would result in a crash in setuptools when the sources are compiled.
See also:
See the builds here:
Open issues which I recommend to be resolved in a separate PR since I will be off for a few days: