Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish pypi #1

Merged
merged 33 commits into from
Jul 18, 2024
Merged

Publish pypi #1

merged 33 commits into from
Jul 18, 2024

Conversation

avigailmo
Copy link
Collaborator

No description provided.

.github/utils/update_project_version.py Outdated Show resolved Hide resolved
.github/utils/update_project_version.py Outdated Show resolved Hide resolved
id: update_version
run: python .github/utils/update_project_version.py ${{ github.event.release.tag_name || inputs.version }}

- name: Commit and push changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this commit the change in the same commit of the release of one commit after it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this action is triggered after the release tag is created (I think there is no commit for the release - only tag). Do we care?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant is that, say you put a release tag 1.1.2 on commit aaa123, but on this commit you still have version 1.1.1.
Then the workflow is triggered and the version changed to 1.1.2 but only on commit bbb123.
Is this how it works?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to handle this.
will do this in a separate pr

src/ugbio-cnv/tests/__init__.py Outdated Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
src/ugbio-cnv/ugbio_cnv/convert_cnv_results_to_vcf.py Outdated Show resolved Hide resolved
src/ugbio-cnv/tests/test_convert_cnv_results_to_vcf.py Outdated Show resolved Hide resolved
src/ugbio-cnv/tests/__init__.py Outdated Show resolved Hide resolved
lfs: true
- name: Install bedtools
run: |
sudo apt-get update
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to install bed tools?

run: |
rye sync
exit_code=0
members=$(rye show | awk '/members:/{flag=1; next} /configured sources:/{flag=0} flag' | awk '{print $1}')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to run tests for all modules on every PR. If someone inserts a bug in another module, the module you are working on is stuck until it is fixed. This way we are keeping the dependencies we want to break

@avigailmo avigailmo merged commit 0c6773f into main Jul 18, 2024
1 check passed
@avigailmo avigailmo deleted the publish_pypi branch July 18, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants