Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the plain Aes.Create() instead of Aes.Create("AesManaged") #747

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Jan 8, 2024

refs #746, #664

There is no indication in the code as to why it explicitly requests the managed AES implementation rather than just using the default, and there are other places in the library that just use Aes.Create(), so this is an attempt at changing it to see if all the tests etc still work.

Also refs https://learn.microsoft.com/en-us/dotnet/api/system.security.cryptography.aes.create?view=net-7.0#system-security-cryptography-aes-create(system-string) which says that the version of Aes.Create that takes a string name has been obsoleted in .NET 7.0

@BobLd BobLd merged commit 8cfaa09 into UglyToad:master Jan 8, 2024
1 check passed
@Numpsy Numpsy deleted the rw/no_managed_aes branch January 8, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants