Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ASAN automatically on make release #125

Closed
wants to merge 1 commit into from
Closed

Disable ASAN automatically on make release #125

wants to merge 1 commit into from

Conversation

mookums
Copy link
Member

@mookums mookums commented Nov 19, 2023

Resolves Issue #118.

Just uses a GNU Make or to check for the LOST_DISABLE_ASAN or the release target.

@markasoftware
Copy link
Member

I'd forgotten to close it but #118 is actually already solved, the line release: LDFLAGS := $(RELEASE_LDFLAGS) does the trick.

@mookums
Copy link
Member Author

mookums commented Nov 19, 2023

😭😭😭

@mookums mookums closed this Nov 19, 2023
@markasoftware
Copy link
Member

If you want to work on an infrastructure-related issue, #26 is the highest priority infrastructure thing IMO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markasoftware markasoftware Awaiting requested review from markasoftware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mookums @markasoftware