Pyramid smart pyramid selection #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think pyramiditerator is a-ok now, but pyramid itself (possibly my new optimization of it?) has some problems...
Forgot to commit the actual test file for this stuff, so it's sitting on my desktop near campus...will need to get that before merging.
|
(Also should test when spectrality is nearly zero before merging) |
No regression test for now, since desired semantics arent totally set in stone yet
markasoftware
force-pushed
the
pyramid-smart-pyramid-selection
branch
from
ec23b7d to
c19296d
Compare
Reusing vectors kind ascary ngl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chooses the pyramid with the smallest sum of distances, which makes matching fast and less likely to have duplicates.
(Need to get back to campus to add a test file i forgot to commit, then this is pretty much ready to go. Could be optimized further by sorting catalog on X coordinate to find nearby stars faster, but that's only a big deal when there are very many stars, and there's a separate issue for that anyway)
(Also split IdentifyPyramid into its own function. In order to do Bayesian stuff, will probably need to modify it again to be parametrized based on pattern size).