Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline Implementation #7

Merged
merged 17 commits into from
Oct 14, 2024
Merged

Pipeline Implementation #7

merged 17 commits into from
Oct 14, 2024

Conversation

heeu0
Copy link
Contributor

@heeu0 heeu0 commented Oct 6, 2024 •
edited by nguy8tri
Loading

Description

Changes from @nguy8tri

  1. Implementation of Pipeline object
  2. Changed coverage artifact to GitHub Style

Changes from @heeu0

  1. Tested @nguy8tri Pipeline Object, all functions are running from my end.

Artifacts for PR #7 (DO NOT CHANGE)

nguy8tri and others added 15 commits April 17, 2023 16:54
@nguy8tri
Added return to main
74a1375
@nguy8tri
Squashed commit of the following:
381d8c4 
commit 86a843f
Author: Tri Nguyen <[email protected]>
Date:   Sat Mar 25 17:24:22 2023 -0700

    Update README to viewable version

commit 00a9764
Merge: bc566cb 8eaa5cf
Author: Tri Nguyen <[email protected]>
Date:   Sat Mar 25 16:37:50 2023 -0700

    Merge pull request #2 from UWCubeSat/interface

    Testing Suite Setup
@nguy8tri
Squashed commit of the following:
d3eefc7 
commit 7b3c7e1
Author: Tri Nguyen <[email protected]>
Date:   Fri Sep 13 10:51:58 2024 -0700

    Refractoring Changes

commit 86a843f
Author: Tri Nguyen <[email protected]>
Date:   Sat Mar 25 17:24:22 2023 -0700

    Update README to viewable version

commit 00a9764
Merge: bc566cb 8eaa5cf
Author: Tri Nguyen <[email protected]>
Date:   Sat Mar 25 16:37:50 2023 -0700

    Merge pull request #2 from UWCubeSat/interface

    Testing Suite Setup
@nguy8tri
Merging from refractor
188e9e7
@nguy8tri
Pipeline Implementation
2b63b30
@nguy8tri
Made initial test and edits to pipeline.*
cf6e505
@nguy8tri
Use constants more
377eee8
@nguy8tri
Squashed commit of the following:
7a1d0f6 
commit f370c67
Author: Tri Nguyen <[email protected]>
Date:   Sat Sep 21 16:21:59 2024 -0700

    Refractor v2 (#6)

commit 0a466d3
Author: Tri Nguyen <[email protected]>
Date:   Sun Sep 15 19:42:02 2024 -0700

    Refractor Code Base for Implementation (#5)

    Merge from pipeline, refractoring changes

    PR: #5

commit 86a843f
Author: Tri Nguyen <[email protected]>
Date:   Sat Mar 25 17:24:22 2023 -0700

    Update README to viewable version

commit 00a9764
Merge: bc566cb 8eaa5cf
Author: Tri Nguyen <[email protected]>
Date:   Sat Mar 25 16:37:50 2023 -0700

    Merge pull request #2 from UWCubeSat/interface

    Testing Suite Setup
@nguy8tri
Merge branch 'main' into pipeline
41304c4
@nguy8tri
Removed catch framework
9b4d331
@nguy8tri
Fixed minor issues
aea1a49
@nguy8tri
Documentation and Quality Changes
6a2711f
@heeu0
pending tests
957cf5b
@heeu0
pipeline tests 100% coverage, all functions work
f2be7c1
@heeu0
Squashed commit of the following:
b410ee9 
commit 1d2c89b
Author: Tri Nguyen <[email protected]>
Date:   Sat Oct 5 17:19:22 2024 -0700

    Example Test bugs

commit adece2b
Author: Tri Nguyen <[email protected]>
Date:   Sat Oct 5 17:11:03 2024 -0700

    Stage extension for all stages
@heeu0 heeu0 requested a review from nguy8tri October 6, 2024 00:26
nguy8tri
nguy8tri requested changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@nguy8tri nguy8tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Hieu, just a few refractoring changes!

test/pipeline/pipeline-test.cpp Outdated Show resolved Hide resolved
test/pipeline/pipeline-test.cpp Outdated Show resolved Hide resolved
test/pipeline/pipeline-test.cpp Outdated Show resolved Hide resolved
test/common/common.hpp Outdated Show resolved Hide resolved
@nguy8tri nguy8tri requested review from zeddie888 and removed request for zeddie888 October 6, 2024 00:44
@nguy8tri nguy8tri self-requested a review October 14, 2024 19:10
@nguy8tri nguy8tri merged commit 3863509 into main Oct 14, 2024
6 checks passed
@nguy8tri nguy8tri deleted the pipeline-test branch October 14, 2024 19:19
nguy8tri added a commit that referenced this pull request Oct 17, 2024
@nguy8tri
Squashed commit of the following:
f48f7aa 
commit 3863509
Author: Hieu Nguyen <[email protected]>
Date:   Mon Oct 14 12:11:23 2024 -0700

    Pipeline Implementation (#7)

    * Added return to main

    * Squashed commit of the following:

    commit 86a843f
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 17:24:22 2023 -0700

        Update README to viewable version

    commit 00a9764
    Merge: bc566cb 8eaa5cf
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 16:37:50 2023 -0700

        Merge pull request #2 from UWCubeSat/interface

        Testing Suite Setup

    * Squashed commit of the following:

    commit 7b3c7e1
    Author: Tri Nguyen <[email protected]>
    Date:   Fri Sep 13 10:51:58 2024 -0700

        Refractoring Changes

    commit 86a843f
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 17:24:22 2023 -0700

        Update README to viewable version

    commit 00a9764
    Merge: bc566cb 8eaa5cf
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 16:37:50 2023 -0700

        Merge pull request #2 from UWCubeSat/interface

        Testing Suite Setup

    * Merging from refractor

    * Pipeline Implementation

    * Made initial test and edits to pipeline.*

    * Use constants more

    * Squashed commit of the following:

    commit f370c67
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Sep 21 16:21:59 2024 -0700

        Refractor v2 (#6)

    commit 0a466d3
    Author: Tri Nguyen <[email protected]>
    Date:   Sun Sep 15 19:42:02 2024 -0700

        Refractor Code Base for Implementation (#5)

        Merge from pipeline, refractoring changes

        PR: #5

    commit 86a843f
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 17:24:22 2023 -0700

        Update README to viewable version

    commit 00a9764
    Merge: bc566cb 8eaa5cf
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 16:37:50 2023 -0700

        Merge pull request #2 from UWCubeSat/interface

        Testing Suite Setup

    * Removed catch framework

    * Fixed minor issues

    * Documentation and Quality Changes

    * pending tests

    * pipeline tests 100% coverage, all functions work

    * Squashed commit of the following:

    commit 1d2c89b
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Oct 5 17:19:22 2024 -0700

        Example Test bugs

    commit adece2b
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Oct 5 17:11:03 2024 -0700

        Stage extension for all stages

    * Revert to C++11

    * Resolving Changes

    ---------

    Co-authored-by: Tri Nguyen <[email protected]>

commit f370c67
Author: Tri Nguyen <[email protected]>
Date:   Sat Sep 21 16:21:59 2024 -0700

    Refractor v2 (#6)

commit 0a466d3
Author: Tri Nguyen <[email protected]>
Date:   Sun Sep 15 19:42:02 2024 -0700

    Refractor Code Base for Implementation (#5)

    Merge from pipeline, refractoring changes

    PR: #5

# Conflicts:
#	src/distance/distance.hpp
#	src/style/style.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguy8tri nguy8tri nguy8tri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heeu0 @nguy8tri