Refractor v2 #6
Merged
Refractor v2 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeddie888
reviewed
Sep 21, 2024
zeddie888
reviewed
Sep 21, 2024
zeddie888
reviewed
Sep 21, 2024
zeddie888
requested changes
Sep 21, 2024
nguy8tri
added a commit
that referenced
this pull request
Sep 21, 2024
author Tri Nguyen <[email protected]> 1726553383 -0700 committer Tri Nguyen <[email protected]> 1726962211 -0700 Trying another deploy-pages target Fixed syntax Modified doccumentation creation Commented out code to see where the problem is Commented out code to see where the problem is Added runs-on Commented out code to see where the problem is Commented out code to see where the problem is Commented out code to see where the problem is added uses to upload pages artifact condensed targets Changed upload pages to v3 Changed to expanded build style to accomodate coverage from different branches Changed to expanded build style to accomodate coverage from different branches Experimenting with higher level directories Fixed experiment Figured that auto-deploying works now? Testing final workflow changes Added double brackets Added auto-install script and changed build workflow CHanged trigger to test workflow Final Changes Changed README.md to use install script Changed workflow to use main instead of master Updated doxygen.sh to update the doxygen file Simplified Doxygen file and redirected stdout into terminal for debugging Different redirection style for stderr and stdout Removed /dev/tty from doxygen.sh Exit on command failure for doxygen.sh for live build Revert error check, because we already check the main error Added workflow for uploading Fixed syntax error Trying another style Comment out require line Taking it out instead Updateing github to github.rest Changed order of headers Changed header to correct position Changed the bodies Update with edit and synchronizing Added console logging for debugging Added console logging for debugging Trying different style Trying even more basic style Changed to ` style quotes to include PR var in string Make the coverage categories different Add better closing workflow Updated install commands Modified install command to actually run alternate scripts PR Changes + shifted valgrind run of test suite to target Improve Readibility for workflow Refractor v2 (#6)
nguy8tri
added a commit
that referenced
this pull request
Sep 22, 2024
commit f370c67 Author: Tri Nguyen <[email protected]> Date: Sat Sep 21 16:21:59 2024 -0700 Refractor v2 (#6) commit 0a466d3 Author: Tri Nguyen <[email protected]> Date: Sun Sep 15 19:42:02 2024 -0700 Refractor Code Base for Implementation (#5) Merge from pipeline, refractoring changes PR: #5 commit 86a843f Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 17:24:22 2023 -0700 Update README to viewable version commit 00a9764 Merge: bc566cb 8eaa5cf Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 16:37:50 2023 -0700 Merge pull request #2 from UWCubeSat/interface Testing Suite Setup
nguy8tri
added a commit
that referenced
this pull request
Oct 14, 2024
* Added return to main * Squashed commit of the following: commit 86a843f Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 17:24:22 2023 -0700 Update README to viewable version commit 00a9764 Merge: bc566cb 8eaa5cf Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 16:37:50 2023 -0700 Merge pull request #2 from UWCubeSat/interface Testing Suite Setup * Squashed commit of the following: commit 7b3c7e1 Author: Tri Nguyen <[email protected]> Date: Fri Sep 13 10:51:58 2024 -0700 Refractoring Changes commit 86a843f Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 17:24:22 2023 -0700 Update README to viewable version commit 00a9764 Merge: bc566cb 8eaa5cf Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 16:37:50 2023 -0700 Merge pull request #2 from UWCubeSat/interface Testing Suite Setup * Merging from refractor * Pipeline Implementation * Made initial test and edits to pipeline.* * Use constants more * Squashed commit of the following: commit f370c67 Author: Tri Nguyen <[email protected]> Date: Sat Sep 21 16:21:59 2024 -0700 Refractor v2 (#6) commit 0a466d3 Author: Tri Nguyen <[email protected]> Date: Sun Sep 15 19:42:02 2024 -0700 Refractor Code Base for Implementation (#5) Merge from pipeline, refractoring changes PR: #5 commit 86a843f Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 17:24:22 2023 -0700 Update README to viewable version commit 00a9764 Merge: bc566cb 8eaa5cf Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 16:37:50 2023 -0700 Merge pull request #2 from UWCubeSat/interface Testing Suite Setup * Removed catch framework * Fixed minor issues * Documentation and Quality Changes * pending tests * pipeline tests 100% coverage, all functions work * Squashed commit of the following: commit 1d2c89b Author: Tri Nguyen <[email protected]> Date: Sat Oct 5 17:19:22 2024 -0700 Example Test bugs commit adece2b Author: Tri Nguyen <[email protected]> Date: Sat Oct 5 17:11:03 2024 -0700 Stage extension for all stages * Revert to C++11 * Resolving Changes --------- Co-authored-by: Tri Nguyen <[email protected]>
nguy8tri
added a commit
that referenced
this pull request
Oct 17, 2024
commit 3863509 Author: Hieu Nguyen <[email protected]> Date: Mon Oct 14 12:11:23 2024 -0700 Pipeline Implementation (#7) * Added return to main * Squashed commit of the following: commit 86a843f Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 17:24:22 2023 -0700 Update README to viewable version commit 00a9764 Merge: bc566cb 8eaa5cf Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 16:37:50 2023 -0700 Merge pull request #2 from UWCubeSat/interface Testing Suite Setup * Squashed commit of the following: commit 7b3c7e1 Author: Tri Nguyen <[email protected]> Date: Fri Sep 13 10:51:58 2024 -0700 Refractoring Changes commit 86a843f Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 17:24:22 2023 -0700 Update README to viewable version commit 00a9764 Merge: bc566cb 8eaa5cf Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 16:37:50 2023 -0700 Merge pull request #2 from UWCubeSat/interface Testing Suite Setup * Merging from refractor * Pipeline Implementation * Made initial test and edits to pipeline.* * Use constants more * Squashed commit of the following: commit f370c67 Author: Tri Nguyen <[email protected]> Date: Sat Sep 21 16:21:59 2024 -0700 Refractor v2 (#6) commit 0a466d3 Author: Tri Nguyen <[email protected]> Date: Sun Sep 15 19:42:02 2024 -0700 Refractor Code Base for Implementation (#5) Merge from pipeline, refractoring changes PR: #5 commit 86a843f Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 17:24:22 2023 -0700 Update README to viewable version commit 00a9764 Merge: bc566cb 8eaa5cf Author: Tri Nguyen <[email protected]> Date: Sat Mar 25 16:37:50 2023 -0700 Merge pull request #2 from UWCubeSat/interface Testing Suite Setup * Removed catch framework * Fixed minor issues * Documentation and Quality Changes * pending tests * pipeline tests 100% coverage, all functions work * Squashed commit of the following: commit 1d2c89b Author: Tri Nguyen <[email protected]> Date: Sat Oct 5 17:19:22 2024 -0700 Example Test bugs commit adece2b Author: Tri Nguyen <[email protected]> Date: Sat Oct 5 17:11:03 2024 -0700 Stage extension for all stages * Revert to C++11 * Resolving Changes --------- Co-authored-by: Tri Nguyen <[email protected]> commit f370c67 Author: Tri Nguyen <[email protected]> Date: Sat Sep 21 16:21:59 2024 -0700 Refractor v2 (#6) commit 0a466d3 Author: Tri Nguyen <[email protected]> Date: Sun Sep 15 19:42:02 2024 -0700 Refractor Code Base for Implementation (#5) Merge from pipeline, refractoring changes PR: #5 # Conflicts: # src/distance/distance.hpp # src/style/style.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refractor targets a few more things:
a. For Linux: Debian, Ubuntu, Redhat, Fedora, CentOS (if there exists apt-get, yum, or dnf)
b. For macOS (via brew)
c. Rejects other OS systems
d. Besides Ubuntu/Debian (so apt-get) and Oracle (so yum), the other installation commands are a bit a shot in the dark and need extra verification, but they appear to be correct
a. Code Coverage is now avaliable via the target coverage, and website is in build/documentation/coverage/index.html
b. Doxygen is now avaliable via the target doxygen_generate, and website is in build/documentation/doxygen/index.html
c. Doxygen is initial, there is no cover page (because right now, we don't really have anything to show perse)
a. Doxygen Build upon Pull Request and for Mainline
b. Code Coverage Generated upon Pull Request and for Mainline
c. Build should be locatable to associate with PRs
Artifacts for PR #6 (DO NOT CHANGE)