Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed syntax and ordering issues #7

Open
wants to merge 1 commit into
base: kubernetes
Choose a base branch
from

Conversation

muhammad-hassnain
Copy link

There were some syntax and ordering issues in the adscraper.sql. It was trying to access relations before they were even created. I have changed the order of commands and fixed some syntax issues. I am attaching the error screenshot and the screenshot of version working.

image
errors

image
fixed

@eric-zeng
Copy link
Collaborator

Thanks for catching these bugs! Apologies for the inconvenience, sometimes when I add fields to tables I update my active database on the fly and don't verify creating the database from scratch.

I think the ordering of creating the crawl table isn't correct though - since page references crawl, crawl will need to exist first.

@eric-zeng eric-zeng force-pushed the kubernetes branch 2 times, most recently from 37ba4e0 to c2997e8 Compare July 31, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants