Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatting drivers folder #51

Merged
merged 15 commits into from
May 13, 2024
Merged

Reformatting drivers folder #51

merged 15 commits into from
May 13, 2024

Conversation

DerekTang04
Copy link
Contributor

@DerekTang04 DerekTang04 commented May 6, 2024

Description

What was completed, changed, or updated?

The folder structure for drivers was changed. Folder names were also changed to snake case. In doing so, CMake files (build and test) also needed to be changed to reflect the new driver file paths. Furthermore, a TM-specific circular buffer was created to have extra functionality with MavLink messages. The TM-specific circular buffer inherits from the original circular buffer. Finally, some edits were made to the dma_uart_device.(cpp/hpp) and drivers_config.(cpp/hpp) for compatibility with TM.


Why was this done (if applicable)?

  1. Drivers folder structure and case update at the direction of Derek Tang
  2. Actual code changes (non Cmake) done to allow driver compatibility with TM
  3. Cmake changes required as driver folder structure was changed.

Testing

What manual tests were used to validate the code?

Firmware and Testing files were successfully compiled


What unit tests were used to validate the code?

N/A


Documentation

Milestone number and name:

Link to Asana task:

Link to Confluence documentation:


Reminders

  • Add reviewers to the PR

  • Mention the PR in the appropriate discord channel

Copy link
Contributor

@StanleyTang17 StanleyTang17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UART DMA device changes LGTM. The rest is nitpicking.

Drivers/common/dma_uart_device/inc/dma_uart_device.hpp Outdated Show resolved Hide resolved
Drivers/common/dma_uart_device/src/dma_uart_device.cpp Outdated Show resolved Hide resolved
Drivers/common/drivers_config/inc/drivers_config.hpp Outdated Show resolved Hide resolved
TelemetryManager/Inc/CircularBuffer.hpp Outdated Show resolved Hide resolved
TelemetryManager/Inc/GroundStationCommunication.hpp Outdated Show resolved Hide resolved
TelemetryManager/Src/CircularBuffer.cpp Outdated Show resolved Hide resolved
Tools/Firmware/CMakeLists.txt Outdated Show resolved Hide resolved
Tools/Testing/CMakeLists.txt Outdated Show resolved Hide resolved
Drivers/common/dma_uart_device/src/dma_uart_device.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@StanleyTang17 StanleyTang17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming it can compile.

@Yaremadzulynsky Yaremadzulynsky merged commit 186cfb0 into main May 13, 2024
2 checks passed
@Yaremadzulynsky Yaremadzulynsky deleted the chore/driver/hot_fix branch May 13, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants