This repository has been archived by the owner on May 25, 2023. It is now read-only.
Geolocation #96
Open
Geolocation #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwinger
force-pushed
the
geolocation
branch
from
2c99eea to
e21e905
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from geolocation code in #79.
I've added unit tests and I think the issues we'd had with the geolocation at the last competition were the fault of the camera profile (specifically the fov) being innaccurate. I've changed the test camera to match the a6000 since the information we have for it is actually accurate (though we admittedly could just use a calculated profile).
We should also probably use tests similar to these to validate all camera profiles we use in future.