Created navigation bar #30
Conversation
| @@ -0,0 +1,64 @@ | |||
| import 'package:flutter/material.dart'; | |||
|
|
|||
| class NavBar extends StatefulWidget { | |||
There was a problem hiding this comment.
Add some documentation in the form of comments, check the other widgets for examples
| @@ -17,6 +18,9 @@ class App extends StatelessWidget { | |||
| ), | |||
| routes: { | |||
| '/': (BuildContext context) => HomePage(title: 'WARG IMACS'), | |||
| '/logs': (BuildContext context) => const Placeholder(child: NavBar()), | |||
There was a problem hiding this comment.
Not exactly a requirement, but you can make the placeholders look a lot nicer
class PlaceholderScreen extends StatelessWidget {
const PlaceholderScreen({Key? key, required this.title}) : super(key: key);
final String title;
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(title),
),
body: const Placeholder(),
bottomNavigationBar: const NavBar());
}
}| } | ||
|
|
||
| class NavBarState extends State<NavBar> { | ||
| int _index = 0; |
There was a problem hiding this comment.
If your going with this implementation, I would actually recommend getting rid of the router and replacing it with a list or map of screen widgets. You'd essentially be replacing the router and making a single screen app with interchangeable screens. Since we are using a router there is some weirdness with the index.
|
|
||
| switch (index) { | ||
| case 0: | ||
| Navigator.of(context).popUntil((route) => route.isFirst); |
There was a problem hiding this comment.
Not really a fan of routing like this, use pushReplacementNamed and popAndPushNamed when possible or replace the router as suggested above.
| Navigator.of(context).popUntil((route) => route.isFirst); | ||
| break; | ||
| case 1: | ||
| Navigator.pushNamed(context, '/logs'); |
There was a problem hiding this comment.
Use pushReplacementNamed or popAndPushNamed or replace the router as suggested above.
| Navigator.pushNamed(context, '/logs'); | ||
| break; | ||
| case 2: | ||
| Navigator.pushNamed(context, '/camera'); |
There was a problem hiding this comment.
Use pushReplacementNamed or popAndPushNamed or replace the router as suggested above.
| Navigator.pushNamed(context, '/camera'); | ||
| break; | ||
| default: | ||
| Navigator.pushNamed(context, '/sitl'); |
There was a problem hiding this comment.
Use pushReplacementNamed or popAndPushNamed or replace the router as suggested above.
With placeholders for camera, logs, and SITL pages.