Rtl button #28
Open
Rtl button #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| /// @return A MissionItem representing the reutrn to launch command. | ||
|
|
||
| MissionItem returnToLaunch(int sequence, int systemID, int componentID, |
There was a problem hiding this comment.
Yeah, I didn't read the docs when I approved this. You need to use a Command Long for this, check set_mode_constructor.dart, that should be similar.
| final MissionItem returnToLaunchConstructor; | ||
|
|
||
| // Requires both the constructor (Mission Item) and comm | ||
| ReturnToLaunch({required this.comm, required this.returnToLaunchConstructor}); |
There was a problem hiding this comment.
You can call the command constructor within the module (look at change_drone_mode for an example)
| await comm.tcpSocketInitializationFlag.future; | ||
| } | ||
|
|
||
| var frame = MavlinkFrame.v2( |
There was a problem hiding this comment.
This part should be done in the command constructor
| @@ -0,0 +1,40 @@ | |||
| import 'package:dart_mavlink/dialects/common.dart'; | |||
| expect(find.text("Return To Launch"), findsOneWidget); | ||
| }); | ||
|
|
||
| testWidgets("Button sends MavLink command", (WidgetTester tester) async {}); |
There was a problem hiding this comment.
If you need help with this test lmk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented code for a return to launch function