Move SteamControllers and _parseMavlinkMessage #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion.dart to get_drone_information.dart
There was a problem hiding this comment.
I made the _tcpSocket var public and added the code below
GetDroneInformation({required this.comm}) {
_listenTcpPort();
_parseMavlinkMessage();
}
_listenTcpPort() async {
await comm.tcpSocketIntializationFlag.future;
comm.tcpSocket.listen(
(Uint8List data) {
_parser.parse(data);
},
onError: (error) {
print(error);
comm.tcpSocket.destroy();
},
);
}This for some reason gets rid of the errors. We should be able to merge once you do something similar for the serial port.
|
|
||
| GetDroneInformation({required this.comm}) { | ||
| _parseMavlinkMessage(); | ||
| comm.stream.listen((Uint8List data) { |
There was a problem hiding this comment.
Instead of doing this, we can make _tcpSocket public (or add getter to it) and listen to it that way, somehow that fixes the bug
| } | ||
|
|
||
| _startupTcpPort(String connectionAddress, int tcpPort) async { | ||
| // Connect to the socket | ||
| _tcpSocket = await Socket.connect(connectionAddress, tcpPort); | ||
| _tcpSocket.listen((Uint8List data) { |
There was a problem hiding this comment.
Move this logic to GetDroneInformation
| StreamController<int> get latStreamController => _latStreamController; | ||
| StreamController<int> get lonStreamController => _lonStreamController; | ||
| StreamController<int> get altStreamController => _altStreamController; | ||
| Stream<Uint8List> get stream => |
There was a problem hiding this comment.
make this for the _tcpSocket instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.