Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console log updates #24

Merged
merged 12 commits into from
Jul 17, 2024
Merged

Console log updates #24

merged 12 commits into from
Jul 17, 2024

Conversation

TheFJcurve
Copy link
Contributor

No description provided.

BalajiLeninrajan
BalajiLeninrajan reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@BalajiLeninrajan BalajiLeninrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good, go through the rest of the modules and add logs whenever you see something important happening, (adding waypoints, changing drone modes, initializing objects, etc.)

BalajiLeninrajan
BalajiLeninrajan reviewed Jul 9, 2024
View reviewed changes
flutter_app/lib/modules/custom_log_functions.dart Outdated
@@ -0,0 +1,9 @@
import 'dart:developer';

void logDroneMode(int? currentMode, String? currentModeName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is making it to complicated, I see where you're coming from but I think it's better to keep it in the widget

BalajiLeninrajan
BalajiLeninrajan reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@BalajiLeninrajan BalajiLeninrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress so far! We need a lot more information from mavlink_communication.dart, like when we the TCP ports and Serial ports are initialized, when instructions are written, etc.

flutter_app/lib/widgets/change_mode_widget.dart Outdated Show resolved Hide resolved
flutter_app/lib/command_constructors/create_waypoint_constructor.dart Outdated Show resolved Hide resolved
BalajiLeninrajan
BalajiLeninrajan reviewed Jul 11, 2024
View reviewed changes
flutter_app/lib/modules/mavlink_communication.dart Outdated Show resolved Hide resolved
flutter_app/lib/modules/mavlink_communication.dart Outdated
break;
case MavlinkCommunicationType.serial:
_startupSerialPort(connectionAddress);
log('Started listening for a Serial connection');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

flutter_app/lib/modules/mavlink_communication.dart Show resolved Hide resolved
flutter_app/lib/modules/mavlink_communication.dart Outdated Show resolved Hide resolved
flutter_app/lib/modules/mavlink_communication.dart Outdated Show resolved Hide resolved
flutter_app/lib/modules/queue_waypoints.dart Show resolved Hide resolved
flutter_app/lib/widgets/drone_information_widget.dart Outdated Show resolved Hide resolved
flutter_app/lib/widgets/change_mode_widget.dart Outdated Show resolved Hide resolved
BalajiLeninrajan
BalajiLeninrajan reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@BalajiLeninrajan BalajiLeninrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to merge soon! I left some nitpicks, other than that you have to restore the home_screen to how it is in main. Also if you have time, maybe add the name of the component the log is from in the log, not necessary but really nice to have.

flutter_app/lib/modules/mavlink_communication.dart Show resolved Hide resolved
flutter_app/lib/modules/change_drone_mode.dart Outdated Show resolved Hide resolved
BalajiLeninrajan
BalajiLeninrajan reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@BalajiLeninrajan BalajiLeninrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single nitpick, otherwise you're basically done

flutter_app/lib/widgets/change_mode_widget.dart Outdated
mavModeGuidedArmed: "Guided Armed",
mavModeAutoArmed: "Auto Armed",
};
const String moduleName = "Change Drone Mode Widget";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change to widgetName

BalajiLeninrajan
BalajiLeninrajan approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@BalajiLeninrajan BalajiLeninrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@TheFJcurve TheFJcurve merged commit e5f051a into main Jul 17, 2024
1 check passed
@TheFJcurve TheFJcurve deleted the console-log-updates branch July 17, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalajiLeninrajan BalajiLeninrajan BalajiLeninrajan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheFJcurve @BalajiLeninrajan