Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/complex #41

Closed
wants to merge 2 commits into from
Closed

Features/complex #41

wants to merge 2 commits into from

Conversation

htanmo
Copy link
Contributor

@htanmo htanmo commented Oct 7, 2024

added more complex functions with better validation and tests.

added better tests, updated function signatures with type annotations and added validation.
Copy link
Contributor

github-actions bot commented Oct 7, 2024

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@github-actions github-actions bot requested a review from UTSAVS26 October 7, 2024 11:27
@UTSAVS26
Copy link
Owner

UTSAVS26 commented Oct 7, 2024

@htanmo please link the issue number.

@htanmo
Copy link
Contributor Author

htanmo commented Oct 7, 2024

@UTSAVS26 it's #17

@UTSAVS26
Copy link
Owner

UTSAVS26 commented Oct 8, 2024

@UTSAVS26 it's #17

I have assigned this issue to @SpreadSheets600, you worked on it, why?

@SpreadSheets600
Copy link
Contributor

@UTSAVS26 it's #17

I have assigned this issue to @SpreadSheets600, you worked on it, why?

You can merge it, he added more operations that aren't there, but make sure he opens up an issue

@UTSAVS26
Copy link
Owner

UTSAVS26 commented Oct 8, 2024

@UTSAVS26 it's #17

I have assigned this issue to @SpreadSheets600, you worked on it, why?

You can merge it, he added more operations that aren't there, but make sure he opens up an issue

He quotes your issue

@htanmo
Copy link
Contributor Author

htanmo commented Oct 8, 2024

So should I open a new issue related to it and reference it or work on a new issue altogther.
@UTSAVS26

@UTSAVS26
Copy link
Owner

UTSAVS26 commented Oct 8, 2024

So should I open a new issue related to it and reference it or work on a new issue altogther.
@UTSAVS26

Yes

@htanmo
Copy link
Contributor Author

htanmo commented Oct 8, 2024

@UTSAVS26 new issue #62 please review and merge it.

@htanmo htanmo closed this Oct 11, 2024
@htanmo htanmo deleted the features/complex branch October 11, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants