-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev to Main | Dependency updates and New Seeks Endpoints #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned to them yet (unclaime) or to list them Endpoint is /api/v1/seeks via GET or PUT Allows claiming a seek for yourself by "joining it". This makes the seek become active and thus now a second player can accept the seek.
…ated - Improved throw exceptions - Reverted "UNCLAIMED" approach for seeks
…move the old seek when creating a new seek instead of allowing a single player to own many seeks.
… rest of the project
…es POST messages about started and ended games
…the two (Seek.uid, Game.seekUid)
…ve unused TestHandler /api/v1/test;
…zoncorretto-21 so that most images are alpine based instead of amazonlinux
… events won't be broadcastet and don't even grow the queue
Add Seek API and game update broadcasting
Bruno tests
chore: update player db schema and update readme
- modify script to accept sqlite location as an argument and make changes directly - updating script documentation - determining next id and providing it to insert (since it is not autoincremented to a default) - check against duplicate names (since DB does not enforce unique names) - added to README
enh: developer script to add a user with trivial password
invaderb
changed the title
Dev o Main | dependency updates and Seeks endpoitns
Dev to Main | Dependency updates and New Seeks Endpoints
Dec 3, 2024
humanat
approved these changes
Dec 3, 2024
nitzel
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs[README]: port and target folder setup, Fix sql-db creation scripts
refactor[Seek ctor+newSeek]: improve parameter names
feat[Seek API]: Add API to create seeks without a player/client assigned to them yet (unclaime) or to list them
Endpoint is /api/v1/seeks via GET or PUT
Allows claiming a seek for yourself by "joining it". This makes the seek become active and thus now a second player can accept the seek.
chore[properties.xml]: Set ports to the ones used on production
docs[README]: Updated with ports used in production/beta/local dev
fix[Seek API]: Send HTTP-Header Content-Type
feat[Seek API]: Only for currently connected players can seeks be created
chore[properties.xml]: Fix db-path default
chore[vscode/settings]: set tabSize=2
chore[SeekDto.java]: format document (tabs->spaces)
fix[Seek]: Assign seek created through the API to the client. Also Remove the old seek when creating a new seek instead of allowing a single player to own many seeks.
chore[indentation]: Fix for new/changed files to use tabs like in the rest of the project
chore[Readme]: Updated HTTP API section
fix[Seek]: Create correct SeekDto by using builder pattern
refactor: Move SeekDto to DTOs folder
feat: Configure global loggin format
feat[GameUpdateBroadcaster] Allow registering an endpoint that receives POST messages about started and ended games
fix[GameDto]: Remove unused member "color"
chore: Remove incorrect comment about komi
feat: Add UUID to Seek and Game so that users of the API can connect the two (Seek.uid, Game.seekUid)
chore: Set default event-subscriber-url to the playtak-api port; Remove unused TestHandler /api/v1/test;
feat: Replace seekUid with pntId
feat: docker
Update .github/deploy.dev.yml to JDK 21
feat: add bruno tests
chore: update player db schema and update readme
enh: developer script to add a user with trivial password
fix: fixing script, docs, implementing feedback
changes directly
autoincremented to a default)
names)
chore: update dependency sqlite version